Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetNewAddress uses hardcoded network value #1466

Closed
JFixby opened this issue Sep 6, 2019 · 6 comments · Fixed by #1467
Closed

GetNewAddress uses hardcoded network value #1466

JFixby opened this issue Sep 6, 2019 · 6 comments · Fixed by #1467
Labels
bug rpc

Comments

@JFixby
Copy link

JFixby commented Sep 6, 2019

Bug line:

btcd/rpcclient/wallet.go

Line 888 in d2b1a06

return btcutil.DecodeAddress(addr, &chaincfg.MainNetParams)

@tylerchambers
Copy link
Contributor

Can you provide a bit more context? Are you referring to MainNetParams?

@JFixby
Copy link
Author

JFixby commented Sep 7, 2019 •
edited
Loading

Because of this line GetNewAddress returns unknown address type-error on any network other than MainNet.

@JFixby JFixby mentioned this issue Sep 7, 2019
Closed
@JFixby
Copy link
Author

JFixby commented Sep 7, 2019 •
edited
Loading

Very much the whole wallet.go-file is corrupted with the same hardcoded network values. There are 6 occurrences of the &chaincfg.MainNetParams

@JFixby
Copy link
Author

JFixby commented Sep 7, 2019

Here is an example of correct implementation: https://github.com/decred/dcrd/blob/1bae334dd9ff797046378e521e3ede4fffcdae14/rpcclient/wallet.go#L968

@Rjected Rjected mentioned this issue Sep 7, 2019
Merged
@Rjected
Copy link
Contributor

Rjected commented Sep 7, 2019

Added a simple fix in #1467

@JFixby JFixby mentioned this issue Sep 20, 2019
Merged
@nikooo777
Copy link

As a consequence of this bug being introduced sometime in April I can't use this library on Bitcoin forks such as LBRY.

Could this please be addressed?

@zquestz zquestz mentioned this issue Nov 21, 2019
Closed
@torkelrogstad torkelrogstad mentioned this issue Jan 17, 2020
Closed
@jakesylvestre jakesylvestre mentioned this issue Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpcclient: Add net params to Client Rjected/btcd
5 participants
@nikooo777 @jcvernaleo @JFixby @tylerchambers @Rjected