RPCS: Failed to marshal reply: rpcversion '' is invalid

[regata]

Seeing this error when calling getinfo using https://github.com/petertodd/python-bitcoinlib:

RPCS: Failed to marshal reply: rpcversion '' is invalid

I'm using the master@2d7825c. I believe it happens because btcd expects jsonrpc field to be provided

btcd/btcjson/jsonrpc.go

Lines 96 to 101 in 2d7825c

	type Request struct {
	Jsonrpc RPCVersion `json:"jsonrpc"`
	Method string `json:"method"`
	Params []json.RawMessage `json:"params"`
	ID interface{} `json:"id"`
	}

when processing RPC requests:

btcd/rpcserver.go

Lines 4152 to 4155 in 2d7825c

	if !batchedRequest {
	var req btcjson.Request
	var resp json.RawMessage
	err = json.Unmarshal(body, &req)

However, bitcoinlib does not send it
https://github.com/petertodd/python-bitcoinlib/blob/0ea83c4fd499c63823754627c69ebdd79dc0d62c/bitcoin/rpc.py#L217-L220

What is the "ground truth" for the rpc spec? is the field expected to be set by clients?

[onyb]

I think this is a regression due to the recently merged JSON-RPC Batch implementation. cc: @jakesyl

We should try to include a fix in 0.22.0 (#1706) - should be quite simple to implement from the look of it. @jcvernaleo

[jcvernaleo]

I was under the impression that the rpcversion was supposed to be there. @jakesyl care to look at this?

[Sjors]

I'm seeing this error too with 0.22 beta... (makes sense, because it's still open)

Changing this line to true was enough to get ForkMonitor to poll it again, but that's a bit of a hack :-)
https://github.com/xplorfin/btcd/blob/master/btcjson/jsonrpc.go#L31

[nikicat]

I still get this error, but it's easy to fix with this commit nikicat@eaac8c9