Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcutil/psbt: finalizer ignores sighash flag when finalizing taproot keyspend signature #2005

Closed
guggero opened this issue Jul 14, 2023 · 0 comments · Fixed by #2006
Closed

btcutil/psbt: finalizer ignores sighash flag when finalizing taproot keyspend signature #2005

guggero opened this issue Jul 14, 2023 · 0 comments · Fixed by #2006
Labels
beginner bug good first issues psbt

Comments

@guggero
Copy link
Collaborator

guggero commented Jul 14, 2023

The finalizer should check the sighash flag in

btcd/btcutil/psbt/finalizer.go

Line 522 in 2dbc98b

serializedWitness, err = writeWitness(pInput.TaprootKeySpendSig)
.
If it is not equal to txscript.SigHashDefault (and the signature is exactly 64 bytes, so it doesn't yet include the sighash flag), it should be appended to the signature.

Related: #2004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner bug good first issues psbt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: missing sighashtype when finalizing taproot keyspend signature Eoous/btcd
1 participant
@guggero