Crypto Go ：we are a research group to help developers build secure applications.

[1047261438]

Hi, we are a research group to help developers build secure applications. We designed a cryptographic misuse detector (i.e., CryptoGo) on Go language. We found your great public repository from Github, and several security issues detected by CryptoGo are shown in the following.
Note that the cryptographic algorithms are categorized with two aspects: security strength and security vulnerability based on NIST Special Publication 800-57 and other public publications. Moreover, CryptoGo defined certain rules derived from the APIs of Go cryptographic library and other popular cryptographic misuse detectors. The specific security issues we found are as follows:
(1) Location: internal/legacy/keystore/keystore.go:2405;
Broken rule: R-06: Not random IV in CFB;
(2) Location: snacl/snacl.go:114;
Broken rule: R-05: the salt of scrypt is constant;
We wish the above security issues could truly help you to build a secure application. If you have any concern or suggestion, please feel free to contact us, we are looking forward to your reply. Thanks.

[Roasbeef]

For the second item (the first is legacy code that is now longer in use), we always initialize the salt from CSPRNG here: https://github.com/btcsuite/btcwallet/blob/master/snacl/snacl.go#L233-L236.