Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better dev-server for testing #481

Closed
btzr-io opened this issue May 10, 2020 · 7 comments
Closed

Use a better dev-server for testing #481

btzr-io opened this issue May 10, 2020 · 7 comments

Comments

@btzr-io
Copy link
Owner

btzr-io commented May 10, 2020

Describe the bug
If we use create-react-app for the component playground demo and the web app it should help keep things more simple and clean.

See #47

@akshay-nm
Copy link

akshay-nm commented Jun 5, 2020

I can work on this one.

@akshay-nm
Copy link

I'll need some directions. I can see that this is a mono repo and this will be my first time with monorepo. Should I just initialize my work as villian-cra in packages dir?

@btzr-io
Copy link
Owner Author

btzr-io commented Jun 8, 2020

I created a react app that runs on the webpack-dev server to test the villain-react component,
I think this added unnecessary config files and dependencies and I want to keep this simple as possible:

Basically all you need to do is:

  • Create a create-react-app inside the villain-react package directory, I suggest to keep the current name: dev-sandbox

  • Move the contents of villain-react/dev-sandbox to the src directory of the new cra .

  • Remove old config files and modules "webpack" etc...

  • Update start command in the package.json, ( make it work for cra )

    "start": "webpack-dev-server --config ./webpack.config.js --mode development --open --hot",

Also I don't think we need another package: villian-cra

@btzr-io
Copy link
Owner Author

btzr-io commented Jun 8, 2020

For the web app, I just want to convert this to a create-react-app and remove the config files and webpack modules, I'm not sure exactly what changes does it need, but I don't think will be that easy 😛

https://github.com/btzr-io/Villain/tree/master/packages/villain-web

@akshay-nm
Copy link

Hahahahahaha... Let me see what I can do. Its 4 am here and I am about to crash. I'll get back with some updates tomorrow.

@btzr-io
Copy link
Owner Author

btzr-io commented Aug 18, 2020

See: #538 (comment)

@btzr-io btzr-io changed the title Use create-react-app for component demo and website Use a better dev-server for testing Sep 2, 2020
@btzr-io
Copy link
Owner Author

btzr-io commented Sep 2, 2020

I'm going to use nollup for the dev-server and remove any webpack usage: https://github.com/PepsRyuu/nollup

@btzr-io btzr-io closed this as completed Sep 2, 2020
@btzr-io btzr-io mentioned this issue Sep 2, 2020
16 tasks
@btzr-io btzr-io added this to the v2.0.0 milestone Sep 3, 2020
@btzr-io btzr-io unpinned this issue Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants