Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'fetchRequestInit' option #210

Merged
merged 1 commit into from
Nov 11, 2021
Merged

feat: add 'fetchRequestInit' option #210

merged 1 commit into from
Nov 11, 2021

Conversation

PerryHuan9
Copy link
Contributor

window.fetch() allow to config

the fetch used in html-to-image should be config. because when image are cross origin , we should use fetch like this:

window.fetch(url, { credentials: 'include' } )

@biiibooo
Copy link
Contributor

biiibooo bot commented Nov 9, 2021

👋 @PerryHuan9

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #210 (3948118) into master (5aa3689) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files          10       10           
  Lines         608      608           
  Branches      118      118           
=======================================
  Hits          468      468           
  Misses         72       72           
  Partials       68       68
Impacted Files Coverage Δ
src/getBlobFromURL.ts 72.97% <ø> (ø)
src/embedWebFonts.ts 72.97% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30000f0...3948118. Read the comment docs.

@PerryHuan9 PerryHuan9 changed the title feat: ✨ add 'fetchRequestInit' option feat: add 'fetchRequestInit' option Nov 9, 2021
@PerryHuan9
Copy link
Contributor Author

Codecov Report

Merging #210 (3948118) into master (5aa3689) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files          10       10           
  Lines         608      608           
  Branches      118      118           
=======================================
  Hits          468      468           
  Misses         72       72           
  Partials       68       68

Impacted Files Coverage Δ
src/getBlobFromURL.ts 72.97% <ø> (ø)
src/embedWebFonts.ts 72.97% <50.00%> (ø)
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30000f0...3948118. Read the comment docs.

sory! Could you tell me how should I do to fix it?

@bubkoo bubkoo merged commit c51da3a into bubkoo:master Nov 11, 2021
@biiibooo biiibooo bot removed the PR: unreviewed label Nov 11, 2021
@biiibooo
Copy link
Contributor

biiibooo bot commented Nov 11, 2021

👋 @PerryHuan9 Congrats on merging your first pull request! 🎉🎉🎉

@biiibooo biiibooo bot added the PR: merged label Nov 11, 2021
@ecrofeg
Copy link

ecrofeg commented Dec 15, 2021

@bubkoo Hi! I'd like to know, when you are planing to release a new version? We are suffering without this feature :(

@fkhasib
Copy link

fkhasib commented Jan 11, 2022

@bubkoo +1 on releasing this new feature in a new release, we need it to load external images from azure blobs
Thanks

@karlnotturno
Copy link

@bubkoo +1 on this too, need it for S3

@pawmanaloto
Copy link

@bubkoo when are you going to release this feature?

@bborn
Copy link

bborn commented Aug 4, 2022

Any update on pushing a release with this?

github-actions bot pushed a commit that referenced this pull request Aug 11, 2022
@semantic-release-bot
chore(release): 1.10.0 [skip ci]
e2821de 
# [1.10.0](v1.9.0...v1.10.0) (2022-08-11)

### Bug Fixes

* 🐛 cloneCSSStyle: copy transformOriginProp ([#297](#297)) ([76b978a](76b978a))
* 🐛 font format could be without qoutation ([#217](#217)) ([2a96149](2a96149))
* 🐛 set selected attribute on option to draw it ([#280](#280)) ([caf97c8](caf97c8))
* 🐛 text breaks on the last word ([#270](#270)) ([062c98a](062c98a))
* test specs ([c7a664e](c7a664e))

### Features

* ✨ add 'fetchRequestInit' option ([#210](#210)) ([c51da3a](c51da3a))
* ✨ added includeQueryParams flag ([#260](#260)) ([259d71e](259d71e))
@biiibooo
Copy link
Contributor

biiibooo bot commented Aug 11, 2022

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@biiibooo biiibooo bot added the released label Aug 11, 2022
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
3daf33e 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
449337f 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
3a19cd3 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
5b715ed 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
be6d29e 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature PR: merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PerryHuan9 @ecrofeg @fkhasib @karlnotturno @pawmanaloto @bborn @bubkoo