Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 selected option not preserved in image #280

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: 🐛 selected option not preserved in image #280

merged 1 commit into from
Aug 10, 2022

Conversation

marcusdelang
Copy link
Contributor

Description

Set selected attribute on the option with a value that corresponds to the value of the select tag.

Motivation and Context

Problem as described in issue #277
The value of select tags is not stored in the html and are thus lost in the clonedNode.

Setting the selected attribute on the option ensures that it is preserved in the final image.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marcusdelang marcusdelang changed the title fix: 🐛 set selected attribute on option to draw it fix: 🐛 selected option not preserved in image Jun 3, 2022
@marcusdelang
Copy link
Contributor Author

@bubkoo Any chance getting this reviewed? 🙏

@biiibooo
Copy link
Contributor

biiibooo bot commented Jul 7, 2022

Hiya!
This PR has gone quiet. Spooky quiet. 👻
We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!
Thanks for being a part of the Antv community! 💪💯

@biiibooo biiibooo bot added the stale label Jul 7, 2022
@bubkoo bubkoo merged commit caf97c8 into bubkoo:master Aug 10, 2022
@biiibooo
Copy link
Contributor

biiibooo bot commented Aug 10, 2022

👋 @marcusdelang Congrats on merging your first pull request! 🎉🎉🎉

github-actions bot pushed a commit that referenced this pull request Aug 11, 2022
@semantic-release-bot
chore(release): 1.10.0 [skip ci]
e2821de 
# [1.10.0](v1.9.0...v1.10.0) (2022-08-11)

### Bug Fixes

* 🐛 cloneCSSStyle: copy transformOriginProp ([#297](#297)) ([76b978a](76b978a))
* 🐛 font format could be without qoutation ([#217](#217)) ([2a96149](2a96149))
* 🐛 set selected attribute on option to draw it ([#280](#280)) ([caf97c8](caf97c8))
* 🐛 text breaks on the last word ([#270](#270)) ([062c98a](062c98a))
* test specs ([c7a664e](c7a664e))

### Features

* ✨ add 'fetchRequestInit' option ([#210](#210)) ([c51da3a](c51da3a))
* ✨ added includeQueryParams flag ([#260](#260)) ([259d71e](259d71e))
@biiibooo
Copy link
Contributor

biiibooo bot commented Aug 11, 2022

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@biiibooo biiibooo bot added the released label Aug 11, 2022
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@marcusdelang @istaiti
fix: 🐛 set selected attribute on option to draw it (bubkoo#280)
0636387
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
3daf33e 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@marcusdelang @istaiti
fix: 🐛 set selected attribute on option to draw it (bubkoo#280)
f2c4f3a
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
449337f 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@marcusdelang @istaiti
fix: 🐛 set selected attribute on option to draw it (bubkoo#280)
a02aeed
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
3a19cd3 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@marcusdelang @istaiti
fix: 🐛 set selected attribute on option to draw it (bubkoo#280)
fab3909
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
5b715ed 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@marcusdelang @istaiti
fix: 🐛 set selected attribute on option to draw it (bubkoo#280)
9a5bbe7
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
@semantic-release-bot @istaiti
chore(release): 1.10.0 [skip ci]
be6d29e 
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix PR: merged released stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusdelang @bubkoo