-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloneCSSStyle): rounded values of d attribute fix #358
Conversation
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all. Closes bubkoo#357
💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportBase: 63.24% // Head: 63.24% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 63.24% 63.24%
=======================================
Files 10 10
Lines 555 555
Branches 129 129
=======================================
Hits 351 351
Misses 146 146
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
👋 @AndrewN93 Congrats on merging your first pull request! 🎉🎉🎉 |
## [1.11.5](v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([#358](#358)) ([6d28bdb](6d28bdb)), closes [#357](#357) * include source in npm package ([#316](#316)) ([b609415](b609415)) * switch lazy loading images to eager ([#359](#359)) ([f7c311b](f7c311b))
🎉 This PR is included in version 1.11.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all. Closes bubkoo#357
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all. Closes bubkoo#357
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all. Closes bubkoo#357
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all. Closes bubkoo#357
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all. Closes bubkoo#357
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30) ### Bug Fixes * **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357) * include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415)) * switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
There is a difference between values in actual d attribute of path and value that returns from window.getComputedStyles() object For some generated svg shapes at particular place is crutial to have exact values in order them to be displayed at all.
Closes #357
Description
There is a problem appears for
![image](https://user-images.githubusercontent.com/31307316/210871718-7d450e9c-4b2c-4895-a620-a91185a2d759.png)
path
elements with precise values ind
attribute on cloneCSSStyle step.window.getComputedStyles()
which is used to get styles to apply them on cloned element returns rounded valueswhich is wrong for some elements.
For e.g here I'm inspecting cloned element and the elements are actually present but because of rounded values after styles were copied they are invisible with height 0 and width 0:
Types of changes
Self Check before Merge