Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove fatalError from BKTClient.shared #18

Merged
merged 11 commits into from
Jul 26, 2023
Merged

fix: remove fatalError from BKTClient.shared #18

merged 11 commits into from
Jul 26, 2023

Conversation

duyhungtnn
Copy link
Collaborator

@duyhungtnn duyhungtnn commented Jul 25, 2023 •
edited
Loading

Why we remove fatalError

  • the fatalError will crash the app, it will not catch with do catch
  • the fatalError should be used in the App context by the app developer, not in the SDK.

@duyhungtnn duyhungtnn marked this pull request as ready for review July 26, 2023 01:49
@duyhungtnn
Copy link
Collaborator Author

@cre8ivejp please help me to take a look on this PR

cre8ivejp
cre8ivejp approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cre8ivejp cre8ivejp merged commit 881de7f into bucketeer-io:main Jul 26, 2023
@bucketeer-bot bucketeer-bot mentioned this pull request Jul 26, 2023
Merged
@bucketeer-bot bucketeer-bot mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ivejp cre8ivejp cre8ivejp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duyhungtnn @cre8ivejp