Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sending duplicate events #24

Merged
merged 6 commits into from
Aug 9, 2023
Merged

fix: sending duplicate events #24

merged 6 commits into from
Aug 9, 2023

Conversation

duyhungtnn
Copy link
Collaborator

Changes

  • Make sure sendEvent() run synchronized in the current queue even with its callback func

Bug fix

@duyhungtnn duyhungtnn force-pushed the 23-fix/bug-send-duplicate-event branch 3 times, most recently from 5e82c14 to e0eaedb Compare August 9, 2023 08:39
@duyhungtnn duyhungtnn force-pushed the 23-fix/bug-send-duplicate-event branch from e0eaedb to d9a9ec3 Compare August 9, 2023 08:40
@duyhungtnn duyhungtnn marked this pull request as ready for review August 9, 2023 08:58
@duyhungtnn
Copy link
Collaborator Author

hi @cre8ivejp please help me to take a look at this PR

cre8ivejp
cre8ivejp approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Thank you!

@cre8ivejp cre8ivejp changed the title feat: send event should run synchronized fix: sending duplicate events Aug 9, 2023
@cre8ivejp cre8ivejp merged commit b84bb58 into bucketeer-io:main Aug 9, 2023
@bucketeer-bot bucketeer-bot mentioned this pull request Aug 9, 2023
Merged
@bucketeer-bot bucketeer-bot mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ivejp cre8ivejp cre8ivejp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: duplicate event because sendEvents it is not synchronized
2 participants
@duyhungtnn @cre8ivejp