Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make APIClient run synchronized #30

Merged

Conversation

duyhungtnn
Copy link
Collaborator

@duyhungtnn duyhungtnn commented Aug 18, 2023

This PR should fix #29 (related to #23)

Changes

  • fix: send event deadlock on EvaluationInteractor
  • removed: semaphore from EvaluationInteractor,
  • using semaphore for making API client run synchronized

@duyhungtnn duyhungtnn force-pushed the fix/make-api-client-run-synchronized branch 5 times, most recently from 92fdaae to fc55ded Compare August 18, 2023 05:20
@duyhungtnn duyhungtnn force-pushed the fix/make-api-client-run-synchronized branch from fc55ded to 6b7502c Compare August 18, 2023 05:21
@duyhungtnn duyhungtnn marked this pull request as ready for review August 18, 2023 05:22
@duyhungtnn
Copy link
Collaborator Author

@cre8ivejp please help me to take a look

@cre8ivejp cre8ivejp force-pushed the fix/make-api-client-run-synchronized branch from 48ceb42 to 2506077 Compare August 21, 2023 16:44
@duyhungtnn
Copy link
Collaborator Author

@cre8ivejp are there any changes we need to make in this PR?

@cre8ivejp cre8ivejp force-pushed the fix/make-api-client-run-synchronized branch from bc1b590 to e2f8d2c Compare August 23, 2023 03:59
@duyhungtnn
Copy link
Collaborator Author

hi @cre8ivejp I changed the logic for flushing events. It will give the app more times to process when the app goes to background mode

df5dfbd

@cre8ivejp cre8ivejp merged commit 0bb11c8 into bucketeer-io:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants