fix: evaluation scheduler not being reset when the request succeeds #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
commented
Aug 30, 2023
| @@ -1,7 +1,7 @@ | |||
| import Foundation | |||
|
|
|||
| final class EvaluationForegroundTask: ScheduledTask { | |||
| private weak var component: Component? | |||
| private let component: Component | |||
There was a problem hiding this comment.
The component at this point can't be nil.
| @@ -20,11 +20,10 @@ final class EvaluationForegroundTask: ScheduledTask { | |||
| self.maxRetryCount = maxRetryCount | |||
| } | |||
|
|
|||
| private func reschedule(isRetrying: Bool) { | |||
| private func reschedule(interval: Int64) { | |||
There was a problem hiding this comment.
Refactored this function to keep the consistency with Android SDK.
Reference: https://github.com/bucketeer-io/android-client-sdk/blob/main/bucketeer/src/main/kotlin/io/bucketeer/sdk/android/internal/scheduler/EvaluationForegroundTask.kt#L23-L31
| // reset the scheduler to use the default polling interval configured in the BKTConfig | ||
| if (retryCount > 0) { | ||
| self?.retryCount = 0 | ||
| self?.reschedule(interval: pollingInterval) |
There was a problem hiding this comment.
Fixes the polling interval setting not being reset when the request succeeds after retrying.
| @@ -93,7 +93,7 @@ final class EvaluationForegroundTaskTests: XCTestCase { | |||
| let task = EvaluationForegroundTask( | |||
| component: component, | |||
| queue: dispatchQueue, | |||
| retryPollingInterval: 1, | |||
| retryPollingInterval: 1000, | |||
There was a problem hiding this comment.
1 millisecond is too low and the test could fail sometimes, so I'm increasing it by 1 second.
|
@cre8ivejp this PR looks good for me. |
masaaania
reviewed
Aug 31, 2023
| featureId: FEATURE_ID_INT, | ||
| featureVersion: 3, | ||
| featureVersion: 4, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thins done