fix: catch network error & add the current timeout setting in the TimeoutErrorMetricsEvent #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyhungtnn
force-pushed
the
fix/network-error-being-reported-as-internal-sdk-error
branch
5 times, most recently
from
c95c2f1 to
e67f301
Compare
|
Verified on a real device |
|
@cre8ivejp its ready for review, please help me to take a look |
duyhungtnn
force-pushed
the
fix/network-error-being-reported-as-internal-sdk-error
branch
2 times, most recently
from
b2cacf6 to
a5b893e
Compare
duyhungtnn
changed the title
duyhungtnn
force-pushed
the
fix/network-error-being-reported-as-internal-sdk-error
branch
3 times, most recently
from
0bdc960 to
1da9f99
Compare
|
@cre8ivejp it's ready for review again. I added the current timeout setting in the TimeoutErrorMetricsEvent |
duyhungtnn
force-pushed
the
fix/network-error-being-reported-as-internal-sdk-error
branch
from
1da9f99 to
ed35c4c
Compare
…eoutErrorMetricsEvent
duyhungtnn
force-pushed
the
fix/network-error-being-reported-as-internal-sdk-error
branch
from
ed35c4c to
f927f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #35 & #16
Changes