fix: .unknow error when handle invalid JSON responses #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyhungtnn
commented
Mar 11, 2024
| ResponseCase(statusCode:500, data: Data("".utf8), name: "Case: empty string"), | ||
| ResponseCase(statusCode:500, data: Data("okay".utf8), name: "Case: random string"), | ||
| ResponseCase(statusCode:500, data: nil, name: "Case: Nil") | ||
| ] |
There was a problem hiding this comment.
Failed
- Case: nil response body
| ResponseCase(statusCode:200, data: Data("".utf8), name: "Case: empty string"), | ||
| ResponseCase(statusCode:201, data: Data("okay".utf8), name: "Case: random string"), | ||
| ResponseCase(statusCode:200, data: nil, name: "Case: Nil") | ||
| ] |
There was a problem hiding this comment.
Failed
- Case: empty string response body
- Case: random string response body
- Case: nil response body
duyhungtnn
changed the title
duyhungtnn
changed the title
|
hi @kakcy , please help me to take a look on this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #64
We added some tests to see how the current code handles invalid JSON responses
Changes
Fixed the issue where the status code couldn't be captured when
This pull request introduces several changes to the
BucketeerSwift package, primarily focusing on improving error handling for API responses. The key changes include updates to theApiClientImplclass to better handle HTTP responses, the addition of a new error type in theResponseErrorenum, and corresponding updates to error handling in theBKTErrorclass. Additionally, there are new test cases inApiClientTestsandBKTErrorTeststo validate these changes.Here are the most important changes:
Improvements to HTTP response handling:
Bucketeer/Sources/Internal/Remote/ApiClientImpl.swift: Updated theresponseParserclosure to handle different scenarios of HTTP responses more accurately. This includes handling cases where the HTTP response is not available, the status code is not within the acceptable range, or the response data is not available or cannot be decoded into the expectedResponsetype.Error handling enhancements:
Bucketeer/Sources/Internal/Remote/ApiClientImpl.swift: Added a new error caseinvalidJSONResponsein theResponseErrorenum to represent scenarios where the response data cannot be decoded into the expectedResponsetype.Bucketeer/Sources/Public/BKTError.swift: Updated theBKTErrorclass to handle the newinvalidJSONResponseerror case from theResponseErrorenum.Test case additions:
BucketeerTests/ApiClientTests.swift: Added new test cases inApiClientTeststo validate the handling of different HTTP response scenarios inApiClientImpl.BucketeerTests/BKTErrorTests.swift: Added a new test case inBKTErrorTeststo validate the handling of the newinvalidJSONResponseerror case inBKTError.