feat: comply with new iOS third-party SDK requirements #86
Conversation
| <plist version="1.0"> | ||
| <dict> | ||
| <key>NSPrivacyTracking</key> | ||
| <false/> |
There was a problem hiding this comment.
NSPrivacyTracking is set to false because we don't track users for displaying ads with IDFA
| <array> | ||
| <dict> | ||
| <key>NSPrivacyCollectedDataType</key> | ||
| <string>NSPrivacyCollectedDataTypeUserID</string> |
There was a problem hiding this comment.
We need the app user_id to make the SDK work correctly.
So we need define we collect the user_id with NSPrivacyCollectedDataTypeUserID
| </dict> | ||
| <dict> | ||
| <key>NSPrivacyCollectedDataType</key> | ||
| <string>NSPrivacyCollectedDataTypeOtherDiagnosticData</string> |
There was a problem hiding this comment.
We collect some info like OS version and app version. So that we need define it with NSPrivacyCollectedDataTypeOtherDiagnosticData
| <string>CA92.1</string> | ||
| </array> | ||
| <key>NSPrivacyAccessedAPIType</key> | ||
| <string>NSPrivacyAccessedAPICategoryUserDefaults</string> |
There was a problem hiding this comment.
We are using the UserDefaults to save the data (e.g. tag, last_evalution_time)
So that we need define it with NSPrivacyAccessedAPICategoryUserDefaults
|
hi @cre8ivejp , @kakcy please help me to take a look |
There was a problem hiding this comment.
@duyhungtnn
Thank you for your response, it is very helpful.
The definition of privacy information looks good.
There are some things I would like to check.
- PrivacyInfo.xcprivacy has not been added to the Xcode project, is this a problem?
- Have you confirmed that it can be used normally from various library management tools (Cocoapod, SPM, Carthage) using sample apps?
Also, I have a suggestion: How about writing Bucketter's policy regarding privacy manifest compliance in the ReadMe?
launchdarkly has such a description, which I thought was good.
|
@kakcy thanks for your comment.
It will be added once you generate the XCode project using XCode Gen. You could try to double-confirm.
Yes, I have tested the example app with a local setup of Cocoapod, SPM.
as the PrivacyInfo.xcprivacy will be added to the XCode-generated project. It will be fine with Carthage
It seems good. However, since May 1st, 2024, any app must define its own |
There was a problem hiding this comment.
Thank you for your reply!
It will be added once you generate the XCode project using XCode Gen. You could try to double-confirm.
I forgot about that, that's for sure.
Yes, I have tested the example app with a local setup of Cocoapod, SPM.
Thank you for testing the operation.
It seems good. However, since May 1st, 2024, any app must define its own PrivacyInfo.xcprivacy to the bundle before submiting a new version to Applestore. That section on the README or document seems not necessary anymore.
What do you think?
I also thought that it was not necessary to write it in the ReadMe because it is essential to deal with it.
Will close #79
This PR adds a new manifest file required to any iOS 3rd SDK from this year. It also included the privacy file to the Swift package and the cocoapods podspec.
The privacy manifest file will be added to the XCode project as a resource file when we generate the XCode project using the XCodeGen.