feat: add ApiClient#getEvaluations #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshrsmz
force-pushed
the
yshrsmz/get_evaluations
branch
from
284dc6d to
e51b319
Compare
yshrsmz
force-pushed
the
yshrsmz/get_evaluations
branch
from
9dce0f3 to
e9350d6
Compare
yshrsmz
commented
Feb 12, 2023
src/internal/model/SourceID.ts
Outdated
Comment on lines
2
to
8
| UNKNOWN: 0, | ||
| ANDROID: 1, | ||
| IOS: 2, | ||
| WEB: 3, | ||
| GOAL_BATCH: 4, | ||
| GO_SERVER: 5, | ||
| NODE_SERVER: 6, |
There was a problem hiding this comment.
@cre8ivejp Is it ok to assume that SourceID is still a number type?
There was a problem hiding this comment.
yshrsmz
force-pushed
the
yshrsmz/get_evaluations
branch
from
e9350d6 to
0d6d52f
Compare
cre8ivejp
reviewed
Feb 13, 2023
src/internal/remote/ApiClient.ts
Outdated
| tag: this.featureTag, | ||
| user, | ||
| user_evaluations_id: userEvaluationsId, | ||
| source_id: SourceID.ANDROID |
There was a problem hiding this comment.
Please use SourceID.JAVASCRIPT.
https://github.com/bucketeer-io/bucketeer/blob/main/proto/event/client/event.proto#L69
| const errorBody: ErrorResponse | null = await response.json() | ||
| const error = errorBody?.error | ||
|
|
||
| switch (response.status) { |
There was a problem hiding this comment.
The server errors have changed a little. Also, the latency and size metrics have changed.
bucketeer-io/android-client-sdk#56
Let me know if you prefer to do this in another PR.
There was a problem hiding this comment.
got it. updated in 801b304 (#13)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.