Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicDataNFTWithMeta 的一些Review意见 #16

Open
waterflier opened this issue Oct 13, 2024 · 1 comment
Open

PublicDataNFTWithMeta 的一些Review意见 #16

waterflier opened this issue Oct 13, 2024 · 1 comment

Comments

@waterflier
Copy link
Member

  1. baseURI 本质上是合约推荐的“金牌矿工地址”,这里应该支持一个列表
  2. 看实现,token_id就是MixHash?
@weiqiushi
Copy link
Member

  1. 单个的baseURI是ERC721的规范,这里倒是可以改成列表,让标准接口返回列表里第一个地址就好了
  2. 对,token id和mix hash的内存表示是一致的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants