Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inheritance for social links. #107

Merged
merged 1 commit into from
May 17, 2018

Conversation

LimitedEdition1
Copy link
Contributor

This allows for social links to be either inherited from config.toml, specific for each page, or completely disabled per page.

@budparr
Copy link
Member

budparr commented May 17, 2018

I like this idea, @LimitedEdition1 Thank you. I'm wondering if we need the global scope on the param here, $.Param "twitter" instead of .Param "twitter"

@LimitedEdition1
Copy link
Contributor Author

I have it working on one of my sites with .Param "key" and seems to do what I expected. I could test the other way too.

@budparr
Copy link
Member

budparr commented May 17, 2018

I would think without it the param would only access it in front matter, not config. I could be wrong though!

@LimitedEdition1
Copy link
Contributor Author

I just did a quick test and they both seem to do the same thing. A live Netlify site works without the $, but
perhaps the $.Param "key" is a preferred method.

@budparr
Copy link
Member

budparr commented May 17, 2018

I think it's fine. I suppose it only needs that scope when it's inside of the context of something else.

@budparr budparr merged commit 10b6b6b into theNewDynamic:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants