Open social media links in new tab and add Medium icon #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svg file pulled from Medium post on their logos and brand guides dated Aug 22, 2017 https://medium.design/logos-and-brand-guidelines-f1a01a733592
Not entirely sure what you mean. You updated the CSS and it appears the file is showing up in the dist folder.
Lastly though I think it would be a good idea to add an accessibility affordance here. Perhaps what Scott Vinkle outlines in this post (skip down to "Example of what I’m talkin’ about"). https://medium.com/@svinkle/why-let-someone-know-when-a-link-opens-a-new-window-8699d20ed3b1 Thanks very much! |
Visible on-hover of link-transition class, this PR also adds a description to the social media icons indicating that they will open in a new window. This way, users will be able to see and hear (via a reader) when a tab will open in a new window. This approach is based on the one outlined here: https://medium.com/@svinkle/why-let-someone-know-when-a-link-opens-a-new-window-8699d20ed3b1
hannahhenderson
force-pushed
the
custom
branch
from
b8b0cab to
3b5916a
Compare
|
Ah, great. I've been using Great call-out on the accessibility affordance. Officially updated. |
hannahhenderson
added a commit
to hannahhenderson/hh-gohugo-theme-ananke
that referenced
this pull request
Nov 27, 2018
…y fields I proposed the Medium icon and accessibility pieces of this PR to the master project in this PR: theNewDynamic#143 (comment) The summary page updates are for me
|
This looks great, @hannahhenderson Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Considerations
static/distfiles updated. Lmk if you'd like to see any changes.:hovercolor as for LinkedIn.UPDATES
Updated to reflect @budparr's input. These new changes include the addition of:
new-windowsvgI reduced the right-margin between social media icons to reduce the spread introduced by the hidden open-in-new-tab
new-windowsvg.