Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this Draft PR I want to get early feedback on my approach for tackling #108 and I would really appreciate some feedback from @budparr, @regisphilibert and anyone else involved.
I implemented a few strings that are easily visible but that should also include most of the strings. This theme is actually quiet and there isn't much text to translate in the first place I think.
I switched to this branch for my own blog and you can see the changes live at: https://blog.jan-steinke.de
So far I only have the translations for "de"(German) and "en"(English). The multi language support build into Hugo should default to "en" if I can trust the documentation, I haven't actually checked if this is true but it should make sure that anyone using this theme with single language should be fine as well.
One thing I consciously removed is the support for
recent_copy
andread_more_copy
as I understood that these are for multi language support and should be unnecessary if we build into i18n support.Things need clarification before WIP is done:
..._copy
parameters