Fix TOC header #168
Merged
Fix TOC header #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In English, the translation that is supposed to be shown on top of the table of contents looks like this:
```toml
[whatsInThis]
other = "What's in this {{.Type }}"
```
When it is invoked, there are two mistakes: `{{ i18n "whatsInThis" humanize .Type }}`.
The first mistake is that you cannot call `humanize` in this context. The more severe one is that if you remove `humanize` it will pass the `.Type` directly to the i18n and that tries to extract `.Type` from it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In English, the translation that is supposed to be shown on top of the table of contents looks like this:
When it is invoked, I think that something is wrong in the calling code:
{{ i18n "whatsInThis" humanize .Type }}.This should be called
{{ i18n "whatsInThis" . }instead because then the i18n can access the.Type; otherwise you get a<no value>output.