Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider checking Cargo.toml snippets for correct version #24

Open
clarfonthey opened this issue May 9, 2017 · 1 comment
Open

Consider checking Cargo.toml snippets for correct version #24

clarfonthey opened this issue May 9, 2017 · 1 comment

Comments

@clarfonthey
Copy link

For example, this crate itself has the block:

[build-dependencies]
skeptic = "0.9"

[dev-dependencies]
skeptic = "0.9"

Let's say that the crate has a breaking change and updates to 0.10, but you forget to change README.md to reflect this. It'd be nice if skeptic could somehow fail and indicate to the user that README.md should be updated to reflect the latest version.

I've had a few crates stumble upon this mistake (including several of my own) and it'd be nice if skeptic could keep track of this too!

@budziq
Copy link
Owner

budziq commented Oct 19, 2017

This should be doable in a basic form as we started to use cargo_metadata to solve some more tricky linkage scenarios.

At the moment I don't think it would be possible to (easily) match against features or dependencies other than crates.io ones (path/vcs), but a basic form that would check if cargo.toml snippet is semver compat with build deps would be possible. Would it be enough @clarcharr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants