Complex Entities cause stack overflow when generating CRDs #351
Labels
bug
Something isn't working
Comments
buehler
added
bug
|
If I recall it correctly, the logic to generate the CRDs is recursive. Maybe there is some error hidden in there :-) I'll have a look, thank you for the report! |
|
FYI this is easy to reproduce by just setting the spec type to [KubernetesEntity(
ApiVersion = "v1alpha1",
Kind = "Cluster",
Group = "xds",
PluralName = "clusters")]
public class V1Alpha1Cluster : CustomKubernetesEntity, IStatus<V1Alpha1ClusterStatus>
{
public V1Alpha1Cluster()
{
}
[PreserveUnknownFields]
public JsonElement? Spec { get; set; }
public V1Alpha1ClusterStatus Status { get; set; }
}
public class V1Alpha1ClusterStatus
{
}Since posting the bug I have also found a better workaround for the issue. I just set the spec type to spec:
properties: {}
type: object
x-kubernetes-preserve-unknown-fields: true |
|
+1 this is also happening if you have any property of type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I have several different classes that were auto generated from these protobufs that appear to contain circular references. When I set one of these classes as the
Specproperty for an entity I will get a stack overflow when doing a build. I am currently working around this by settingIgnoreEntityattribute on the kubernetes entity and manually creating/updating the CRD.Because of how complex the spec type is, I have just been setting the
typeas object and addingx-kubernetes-preserve-unknown-fields: trueto the property in the CRD schema.Describe the solution you'd like
Ideally I would like an attribute I can set on my
Specproperties that will create an emptypropertiesand settype: objectandx-kubernetes-preserve-unknown-fields: true. A solution could be to add anIgnoreEntityPropertyAttributeand if that is set in combination withPreserveUnknownFieldsAttributethen the generated CRD for that property would look like:Additional context
For reference, below is a shortened version of the stack trace for the stack overflow exception:
The text was updated successfully, but these errors were encountered: