fix: don't access disposed resources #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachtjasmin
force-pushed
the
fix/async-disposable
branch
from
c047dbd to
3d1ffad
Compare
|
Thank you @nachtjasmin :-) Wow, I did not remember these async patterns to be this verbose 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ensuring that the host does not stop with an exception. Those exceptions were occuring because the
CancellationTokenSourceinside the hosted services was already disposed whenStopAsyncgot called.The reason for this is that the host invokes
DisposeAsyncbeforeStopAsync.