New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make this work on Windows #3

Closed

bugdea1er opened this issue Jan 27, 2024 · 1 comment · Fixed by #26

Labels

Owner

bugdea1er commented Jan 27, 2024 •

edited

Loading

Files and directories are created with mk*temp functions from the unistd.h header. These do not exist on Windows

The text was updated successfully, but these errors were encountered:

bugdea1er changed the title ~~Make it work on Windows~~ Make this work on Windows

bugdea1er linked a pull request

that will close this issue

Add Windows support #26

Merged

bugdea1er added the help wanted label

Owner Author

bugdea1er commented May 12, 2024

What needs to be done:

make_pattern should be updated to return a proper pattern for Windows API
create_file should be updated to work on Windows. Seems like GetTempFileNameW is a good choice to create a proper temporary file for a given template
create_directory should be updated, but I couldn't find a proper function in Windows
Conversion from system error code to a fs::filesystem_error should support Windows GetLastError

bugdea1er closed this as completed in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment