SIGABRT in notifyError

[benasher44]

Description

Issue

We're seeing a SIGABRT inside of Bugsnag in the call to notifyError:….

Here's the trace:

SIGABRT: 

0  libsystem_kernel.dylib  ___pthread_kill
1  libsystem_pthread.dylib _pthread_kill
2  libsystem_c.dylib       _abort
3  libsystem_malloc.dylib  _malloc_vreport
4  libsystem_malloc.dylib  _malloc_report
5  libsystem_malloc.dylib  _free
6  PlanGrid                bsg_ksstring_replace (BSG_KSString.c:143:9)
7  PlanGrid                bsg_kscrash_reinstall (BSG_KSCrashC.c:194:5)
8  PlanGrid                -[BSG_KSCrash reportUserException:reason:originalException:handledState:appState:callbackOverrides:metadata:config:discardDepth:terminateProgram:] (BSG_KSCrash.m:324:5)
9  PlanGrid                -[BugsnagCrashSentry reportUserException:reason:originalException:handledState:appState:callbackOverrides:metadata:config:discardDepth:] (BugsnagCrashSentry.m:53:5)
10 PlanGrid                -[BugsnagNotifier notify:handledState:block:] (BugsnagNotifier.m:665:5)
11 PlanGrid                -[BugsnagNotifier notifyError:block:] (BugsnagNotifier.m:530:5)

Environment

Library versions:

• Bugsnag version (from your Podfile, Podfile.lock, or elsewhere): 5.22.4
• CocoaPods version (if any) (pod -v): 1.7.2
• Carthage version (if any):
• iOS/tvOS/macOS version(s) iOS 11+
• debug mode or production?: Production
• How are you initializing Bugsnag? Can you share a snippet of your
  AppDelegate where Bugsnag is configured?

Example code snippet

import Bugsnag
// title is a String
// message is a String
// severity is an enum, which we map to a Bugsnag severity
        let bugsnagError = NSError(domain: "com.loupe.PlanGrid", code: 0, userInfo: [
            NSLocalizedDescriptionKey: title,
            NSLocalizedFailureReasonErrorKey: message
        ])

        Bugsnag.notifyError(bugsnagError) { report in
            report.errorClass = title
            report.errorMessage = message
            report.severity = severity.bugsnagSeverity
            additionalData?.forEach { key, value in
                report.metaData[key] = value
            }
            report.context = "ErrorLogger.logError"
        }

Here's the ID of the error in the plangrid iOS Bugsnag project :) 5c86619cc74b1f0019fc8ecc. Feel free to go have a look!

[kattrali]

Thanks for the report, @benasher44. I took a look and have some theories. Will report back soon.

[benasher44]

Thank you!

[kattrali]

Found a reproduction case involving calling notify concurrently from a few queues at once. Working on a fix in #401.

[abigailbramble]

@benasher44 this is now fixed in https://github.com/bugsnag/bugsnag-cocoa/releases/tag/v5.22.5

[benasher44]

Great thank you! 🎉