Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expo-doctor showing error from bugsnag dependency #205

Open
2 tasks
VicFrolov opened this issue Dec 29, 2024 · 3 comments
Open
2 tasks

expo-doctor showing error from bugsnag dependency #205

VicFrolov opened this issue Dec 29, 2024 · 3 comments
Labels
awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks.

Comments

@VicFrolov
Copy link

VicFrolov commented Dec 29, 2024

Describe the bug

The key issue appears to be:

@expo/config-plugins@8.0.11 dev peer
node_modules/@expo/config-plugins
  @expo/config-plugins@"~8.0.8" from @expo/config@9.0.4
  node_modules/@expo/config
    peer @expo/config@"^9.0.1" from @bugsnag/plugin-expo-eas-sourcemaps@52.0.0

The problem is coming from @bugsnag/plugin-expo-eas-sourcemaps@52.0.0 which has a peer dependency on an older version of @expo/config (^9.0.1).

Steps to reproduce

  1. Start new expo 52 project, add bugsnag via cli tool
  2. run npx expo-doctor@latest to see error

Environment

  • Bugsnag version: 52
  • Expo SDK version (e.g. SDK 44): 52
  • Device (e.g. iphonex): iPhone X

Example Repo

  • Create a minimal repository that can reproduce the issue
  • Link to it here:

Example code snippet

// deps
"@bugsnag/expo": "^52.0.0",

// dev deps
"@bugsnag/plugin-expo-eas-sourcemaps": "^52.0.0",
"@bugsnag/source-maps": "^2.3.3",
Error messages:
Detailed check results:

Expected package @expo/config-plugins@~9.0.0
Found invalid:
  @expo/config-plugins@8.0.11
  (for more info, run: npm why @expo/config-plugins)
Advice: Upgrade dependencies that are using the invalid package versions.
@agrzegorzewski
Copy link

Hi @VicFrolov,

Thanks for reaching out.

Unfortunately, we were unable to reproduce this issue when running expo-doctor in a similar project. Creating a fresh Expo 52 project and adding BugSnag does not throw any errors about the @expo/config dependency.

Could you please try reinstalling all of the offending dependencies? If that does not solve the issue, could you please share your package.json and package-lock.json files? In case you’re not comfortable sharing them in a public GitHub thread, please reach out to us at support@bugsnag.com.

@agrzegorzewski agrzegorzewski added the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jan 7, 2025
@ronb54
Copy link

ronb54 commented Jan 28, 2025

I'm on a similar expo SDK version as @VicFrolov at v52. Installing @bugsnag/source-maps fails:

> npm install --save-dev @bugsnag/source-maps
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: my-app@1.0.0
npm error Found: @expo/config@10.0.8
npm error node_modules/@expo/config
npm error   @expo/config@"^10.0.8" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @expo/config@"^9.0.1" from @bugsnag/plugin-expo-eas-sourcemaps@52.0.0
npm error node_modules/@bugsnag/plugin-expo-eas-sourcemaps
npm error   dev @bugsnag/plugin-expo-eas-sourcemaps@"^52.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error

I just looked at https://github.com/bugsnag/bugsnag-expo/blob/v52/next/packages/plugin-expo-eas-sourcemaps/package.json

Shouldn't @expo/config here be set to 10.0.8?

@enagorny
Copy link

It is possible to use npm overrides. Add this to your package.json:

  "overrides": {
    "@expo/config": "~10.0.8"
  },

But agree ideally bugsnag team update it in the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks.
Projects
None yet
Development

No branches or pull requests

4 participants