Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugsnag.ErrorClass is ignored on v1.4.0 #98

Closed
terashi58 opened this issue Jan 25, 2019 · 3 comments · Fixed by #116
Closed

bugsnag.ErrorClass is ignored on v1.4.0 #98

terashi58 opened this issue Jan 25, 2019 · 3 comments · Fixed by #116

Comments

@terashi58
Copy link

Expected behavior

Reported error class is specified by bagsnag.ErrorClass in metadata.

Observed behavior

Reported error class is the reflected type name of error.

Steps to reproduce

err := errors.New("msg")
bugsnag.Notify(err, bugsnag.ErrorClass("ExpectedErrorClass"))

Version

v1.4.0

Additional information

It worked until v1.3.2.
I believe the order of concatenated raw data in Notifier and the Event construction by error caused this issue.

@ibrt
Copy link

ibrt commented Mar 22, 2019

Ran into this issue as well, and diagnosed it in the same way. Please fix, it's very annoying.

BTW, this is a possible workaround:

bugsnag.OnBeforeNotify(func(event *bugsnag.Event, cfg *bugsnag.Configuration) error {
	event.ErrorClass = ...
	return nil
})

@kinbiko
Copy link
Contributor

kinbiko commented Mar 25, 2019

Hi @terashi58, @ibrt,

Thanks for flagging this one up. Apologies for this, I can see how this is an annoying bug and I'll try and get this fixed in the next couple of weeks. In the meantime, the workaround @ibrt suggested should do the trick.

@kinbiko
Copy link
Contributor

kinbiko commented Apr 16, 2019

Hi again,

Sorry about the wait. This issue is now fixed in v1.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants