Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Upload Hermes sourcemaps generated by CodePush #463

Closed
rcstanciu opened this issue Jun 23, 2020 · 1 comment
Closed

Upload Hermes sourcemaps generated by CodePush #463

rcstanciu opened this issue Jun 23, 2020 · 1 comment

Comments

@rcstanciu
Copy link

Description

Currently, on each OTA update using CodePush, I have to trigger an Android full build in order to generate the Hermes bundle & sourcemaps, found in android/app/build/generated/assets/react/release/index.android.bundle and android/app/build/generated/sourcemaps/react/release/index.android.bundle.map as stated in the docs:
https://docs.bugsnag.com/platforms/react-native/react-native/showing-full-stacktraces/#uploading-hermes-source-maps

As CodePush generates the JS bundle, as well as the Hermes byte-code bundle and sourcemaps, is there any way we can use these instead of those generated by the Android build?

Issue

I tried uploading CodePush's Hermes byte-code bundle and sourcemap to Bugsnag, I did not get any errors like "Unable to apply sourcemap", but the stacktrace is gibberish:

Screenshot 2020-06-23 at 23 13 24

Environment

Library versions:

yarn list v1.22.4
├─ bugsnag-react-native@2.23.8
├─ react-native-code-push@6.2.0
└─ react-native@0.62.2
@xljones
Copy link

xljones commented Jun 24, 2020

Hey @rcstanciu, it's a known 'issue' with the CodePush / Hermes combo. The Hermes map is rendered in a binary format when produced through CodePush which is what you're seeing here.

Hopefully when the issue we raised here facebook/hermes#85 is resolved, we'll be able to take a look into whether we can use the CodePush output files. In the meantime, what you were doing before with the Android build is correct!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants