Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit zero-sized CAS blob #56

Closed
moroten opened this issue Apr 15, 2020 · 2 comments
Closed

Add implicit zero-sized CAS blob #56

moroten opened this issue Apr 15, 2020 · 2 comments

Comments

@moroten
Copy link
Contributor

moroten commented Apr 15, 2020

During the monthly https://github.com/bazelbuild/remote-apis meeting 2020-04-14, the following was decided:

We should standardize this. Servers should allow references to the empty blobs, and should support serving the empty blob even if it has not been uploaded. Clients should feel free to optimize within this to avoid uploading or downloading empty blobs.

Implementing this will sort out the Bazel behaviour mentioned in bazelbuild/bazel#11063.

@EdSchouten
Copy link
Member

It's a pity we didn't use the occasion to simply say: digests with size zero are not allowed to exist. It's either a nil digest, or a digest with a size > 0. That would have solved this problem in a far more natural and less ambiguous way. But I guess we're simply getting to the point that we all have to be bug for bug compatible with Bazel. Great.

@mostynb
Copy link
Contributor

mostynb commented Apr 16, 2020

It's a pity we didn't use the occasion to simply say: digests with size zero are not allowed to exist. It's either a nil digest, or a digest with a size > 0.

I had the same thought when implementing this for bazel-remote. Something to suggest for REAPIv3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants