-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use run image digest if it exists in local daemon copy #278
Comments
I have the feeling that this should append in the lifecycle, not in pack, right? |
@dgageot is right that the lifecycle adds this label. I think the change actually needs to be made in |
lower level issue: buildpacks/imgutil#32 |
Potentially related buildpacks/rfcs#203 |
Description
In exploring the issue of reproducibility, I unpacked why we have different configurations for the following cases:
Case 1 (create image locally and push)
*Case 2 (create image remotely with --publish)
I then fetched the configs and dug into them, which turned up the following diff, which is what I thought would be the case:
However, the run image used in the local case exists in my local daemon, and has a digest reference:
Proposed solution
If the local image has a single digest entry in its docker config (
config.RepoDigest
) we can populate theio.buildpacks.lifecycle.metadata.reference
field with that data and therefore end up with the same configuration.Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: