-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove validation of deprecated io.buildpacks.stack.id
#2104
Labels
good first issue
A good first issue to get started with.
status/ready
Issue ready to be worked on.
type/bug
Issue that reports an unexpected behaviour.
Milestone
Comments
matthewrobertson
added
status/triage
Issue or PR that requires contributor attention.
type/bug
Issue that reports an unexpected behaviour.
labels
Mar 20, 2024
This might benefit from some synchronous discussion so I've added it as a "future topic" for one of our Working Groups |
natalieparellano
added
status/discussion-needed
Issue or PR that requires in-depth discussion.
and removed
status/triage
Issue or PR that requires contributor attention.
labels
Mar 26, 2024
Discussed in 3/28 Working Group: we think we can replace the error with a warning. The warning should probably note that stacks are deprecated so that folks who are not using stacks can simply ignore it. |
natalieparellano
added
status/ready
Issue ready to be worked on.
and removed
status/discussion-needed
Issue or PR that requires in-depth discussion.
labels
Mar 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
A good first issue to get started with.
status/ready
Issue ready to be worked on.
type/bug
Issue that reports an unexpected behaviour.
Summary
Pack still has logic that validates the builder and run image have a matching value set for the
io.buildpacks.stack.id
here. This label is deprecated as of platform v0.12 so we should probably weaken this validation.Reproduction
Run a pack build using a packeto builder and google run image:
Current behavior
Build fails with an error message about mistmatched stack IDs
Expected behavior
The builder and run image are both derived from Ubuntu Jammy so we should allow the build proceed
Environment
Linux
pack info
All versions of pack impacted
docker info
N/A
The text was updated successfully, but these errors were encountered: