Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for injecting modules on command line #1445

Closed
shahzebsiddiqui opened this issue Apr 18, 2023 · 2 comments · Fixed by #1503
Closed

Add code coverage for injecting modules on command line #1445

shahzebsiddiqui opened this issue Apr 18, 2023 · 2 comments · Fixed by #1503
Assignees
Labels
good first issue good first issue for new contributor regression-test issues related to regression test or missing code coverage

Comments

@shahzebsiddiqui
Copy link
Member

We are not testing buildtest build --modules and buildtest build --unload-modules in the test coverage. This can be found in https://app.codecov.io/gh/buildtesters/buildtest/blob/devel/buildtest/builders/base.py under following section.

Screen Shot 2023-04-18 at 3 58 42 PM

In addition we might also want to test for module purge buildtest build --module-purge

@shahzebsiddiqui shahzebsiddiqui added the regression-test issues related to regression test or missing code coverage label Apr 18, 2023
@shahzebsiddiqui shahzebsiddiqui added the good first issue good first issue for new contributor label May 25, 2023
@shahzebsiddiqui
Copy link
Member Author

@kingxleyy i will be assigning this task to you

@shahzebsiddiqui
Copy link
Member Author

shahzebsiddiqui commented Jun 21, 2023

HINT

@shahzebsiddiqui shahzebsiddiqui linked a pull request Jul 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue good first issue for new contributor regression-test issues related to regression test or missing code coverage
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants