Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null-Safety Migration #283

Closed
GoldenSoju opened this issue Mar 10, 2021 · 13 comments
Closed

Null-Safety Migration #283

GoldenSoju opened this issue Mar 10, 2021 · 13 comments

Comments

@GoldenSoju
Copy link
Contributor

I haven't found any entry about it yet, so I was wondering if the package will be migrated to null-safety (soon) ?

@andzejsw
Copy link
Contributor

I have created pull request implementing null safety logic: #286
Hope soon it will be implemented and if needed, improved.

@thomassth
Copy link
Contributor

I have created pull request implementing null safety logic: #286
Hope soon it will be implemented and if needed, improved.

On my I did the same thing
#287

Can we combine our work in some way

@andzejsw
Copy link
Contributor

I have created pull request implementing null safety logic: #286
Hope soon it will be implemented and if needed, improved.

On my I did the same thing
#287

Can we combine our work in some way

We can try if there is need. But first i think that project maintainers and owner should take a look. But yeah, I will take a look on your PR.

@GoldenSoju
Copy link
Contributor Author

i haven't seen any activity from the package owner(s) for a while now...can we assume this package was abandoned?

@andzejsw
Copy link
Contributor

i haven't seen any activity from the package owner(s) for a while now...can we assume this package was abandoned?

I think that it is safe to say that. Some very needed PR aren't touched for quite some time.

@thomassth
Copy link
Contributor

I don't mind splitting and republish the package to pub.dev, at least it's more convenient.
But I don't have much experience in coding, I can take pull requests but probably can't contribute much.

@nickrandolph
Copy link
Contributor

nickrandolph commented Apr 20, 2021

Hey all, again apologies, I've had other work commitments. If you guys are interested I can add you as maintainers as happy to take contributors.
Just as FYI the build and publish is pretty much automated, so it's just a matter of raising PRs to the appropriate branch. If you're interested, I'd be happy to help you guys contribute

@andzejsw
Copy link
Contributor

andzejsw commented Apr 21, 2021

Hey all, again apologies, I've had other work commitments. If you guys are interested I can add you as maintainers as happy to take contributors.
Just as FYI the build and publish is pretty much automated, so it's just a matter of raising PRs to the appropriate branch. If you're interested, I'd be happy to help you guys contribute

In my opinion @thomassth PR now is better than mine. But yeah, i would be happy to be a maintainer, if you need any help. Probably @thomassth has no problem with that too.

@nickrandolph
Copy link
Contributor

@thomassth and @andzejsw I've sent you invites to the Other team at Built to Roam. Let me know if you have any issues accepting the invites

@andzejsw
Copy link
Contributor

@thomassth and @andzejsw I've sent you invites to the Other team at Built to Roam. Let me know if you have any issues accepting the invites

Hi. I don't see any invite.

@nickrandolph
Copy link
Contributor

Do you have a different email account associated with your github account?

@thomassth
Copy link
Contributor

I got the invite when I visit https://github.com/builttoroam

@andzejsw
Copy link
Contributor

Merged PR #287 into develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants