Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] rrule compatability #446

Open
thomassth opened this issue Oct 7, 2022 · 4 comments
Open

[5.0] rrule compatability #446

thomassth opened this issue Oct 7, 2022 · 4 comments
Labels
documentation Something worth becoming documentation hacktoberfest help wanted This issue is open for someone to pick up and action

Comments

@thomassth
Copy link
Contributor

Part of #445

After #403, quite a lot of recurrence rules have changed; hence

  1. point to rrule document where relevant
  2. provide some campatability to the old recurrenceRule, if it is not taking too much effort to maintain
  3. remove old references and documents to old methods
@thomassth thomassth added help wanted This issue is open for someone to pick up and action documentation Something worth becoming documentation hacktoberfest labels Oct 7, 2022
@thomassth
Copy link
Contributor Author

WeekOfDay is not included in rrule it seems.

Right now the plan is to wait until it is solved on rrule side, but a 5.0 prerelease can go ahead.

@GoldenSoju
Copy link
Contributor

@thomassth

WeekOfDay is not included in rrule it seems.

Right now the plan is to wait until it is solved on rrule side, but a 5.0 prerelease can go ahead.

If you refer to Implementing weekofmonth, please check if my reply is correct.

@thomassth
Copy link
Contributor Author

I suspected it has something to do with BYDAY but I didn't have time to investigate it

As long as it's the same as how the Android/iOS did things, I am ok with that.

@GoldenSoju
Copy link
Contributor

Yes, in the end they all use the same recurrence rule standard.
For iOS documentation it would be EKRecurrenceDayOfWeek.

@thomassth thomassth mentioned this issue Oct 12, 2022
Draft
10 tasks
@IVLIVS-III IVLIVS-III mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Something worth becoming documentation hacktoberfest help wanted This issue is open for someone to pick up and action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomassth @GoldenSoju