Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickr Sample API - 'getLargerSizeKeys' always returns an empty List #4121

Closed
valentinilk opened this issue Mar 1, 2020 · 1 comment · Fixed by #4141
Closed

Flickr Sample API - 'getLargerSizeKeys' always returns an empty List #4121

valentinilk opened this issue Mar 1, 2020 · 1 comment · Fixed by #4141
Labels

Comments

@valentinilk
Copy link

There is a small error in the 'getLargerSizeKeys' method in the Flickr sample. It always returns an empty List.

List<String> result = new ArrayList<>();
int size = result.size();
for (int i = 0; i < size; i++) {
    // [...]
}

It should most probably be:

List<String> result = new ArrayList<>();
int size = SORTED_SIZE_KEYS.size();
for (int i = 0; i < size; i++) {
    // [...]
}

The line in question can be found here:

I'll gladly create a pull request if preferred.

@sjudd
Copy link
Collaborator

sjudd commented Mar 5, 2020

Thanks for the report, please do send a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants