[Compose] Modifier is applied twice

[ln-12]

Glide Version: 4.16.0 / 1.0.0-alpha.5

Device/Android Version: compose preview, Pixel 7, Emulator (both API 33)

Issue details / Repro steps / Use case background:

I noticed that modifiers which are applied to a GlideImage, are applied twice. In the example shown below, you can see that the padding as well as the background modifier are applied two times. The expected behavior is that each modifier is only applied once so that the padding is actually only 10.dp and that the background is only visible once too.

My code example looks like this:

Column(
        modifier = Modifier.background(Color.Red)
) {
    GlideImage(
            model = R.drawable.lb_background,
            contentDescription = null,
            modifier = Modifier
                .padding(10.dp)
                .background(Color.Green)
                .height(150.dp)
                .fillMaxWidth()
                .clip(RoundedCornerShape(10.dp))
                .background(Color.Yellow),
            contentScale = ContentScale.Crop,
    )
}

As far as I can tell, the issue is related to this code block:

glide/integration/compose/src/main/java/com/bumptech/glide/integration/compose/GlideImage.kt

Lines 120 to 153 in b1c6076

	GlideSubcomposition(model, modifier, { requestBuilder }) {
	if (state == RequestState.Loading && loadingComposable != null) {
	loadingComposable()
	} else if (state == RequestState.Failure && failureComposable != null) {
	failureComposable()
	} else {
	Image(
	painter,
	contentDescription,
	modifier,
	alignment,
	contentScale,
	alpha,
	colorFilter,
	)
	}
	}
	} else {
	SimpleLayout(
	modifier
	.glideNode(
	requestBuilder,
	contentDescription,
	alignment,
	contentScale,
	alpha,
	colorFilter,
	transition,
	loadingPlaceholder = loading?.maybePainter(),
	errorPlaceholder = failure?.maybePainter(),
	)
	)
	}
	}

The modifier that is provided to GlideImage is passed on to both GlideSubcomposition and each of the child composables which causes the duplication. The solution would be to either use the modifier on the GlideSubcomposition OR use it one the child composables.

[sjudd]

Thanks, I think your bug is a duplicate of #5272 because I don't see you using GlideSubcomposition or providing a composable placeholder, so you won't hit the codepath in GlideImage you pointed out.

That said, It may still be a bug that the modifier is applied twice, so I'll leave this open. If we do submit #5306, then this will be "fixed" (as in deleted) as well.