Uncaught TypeError when listing NoteAttachmentMasterCardAction

[basst85]

Steps to reproduce:

I'm using this code:

$mastercardActions = MasterCardAction::listing($monetaryAccountId)->getValue();
$mastercardActionId = $mastercardActions[0]->getId();
$mastercardActionAttachments = NoteAttachmentMasterCardAction::listing($mastercardActionId,$monetaryAccountId)->getValue();

But it's returning this error:

Fatal error: Uncaught TypeError: Argument 1 passed to bunq\Model\Core\BunqModel::createFromResponseArray() must be of the type array, integer given, called in /var/www/domain.com/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php on line 242 
and defined in /var/www/domain.com/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php:103 Stack trace: #0 /var/www/domain.com/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php(242): bunq\Model\Core\BunqModel::createFromResponseArray(3647492, NULL) #1 /var/www/domain.com/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php(207): bunq\Model\Core\BunqModel::createListFromResponseArray(Array) #2 /var/www/domain.com/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php(165): bunq\Model\Core\BunqModel::determineFieldContents(Object(ReflectionProperty), Array) #3 /var/www/domain.com/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php(119): bunq\Model\Core\BunqModel::createInstanceFromResponseArray(Array) #4 /var/www/domain.com/ in /var/www/domain.com/vendor/bunq/sdk_php/src/Model/Core/BunqModel.php on line 103

What should happen:

1. Return a JSON object with attachments

What happens:

1. Retuns an error

Traceback

SDK version and environment

• Tested on 1.1.0
• Sandbox
• Production

Response id

None

[OGKevin]

hmm, @kojoru sounds like a view definition error. Same as #76

[OGKevin]

@basst85 if you enable debugger you should be able to see/find out what its trying to deserialise and fix it by doing something like #76 (comment)

[basst85]

@OGKevin @kojoru There is something "strange" with the returnvalue of $responseArray in the function fromJsonList() (in BunqModel):
https://pastebin.com/ciGZ7k6L

The attachment object in the end of the file is strange.. ?

The response JSON:
https://pastebin.com/RbfsYRNW

[OGKevin]

found it :)

          "attachment": {
                "id": 3647492,
                "description": "",
                "content_type": "image\/jpeg"
            }

is an object but, this is how it's defined:

sdk_php/src/Model/Generated/Endpoint/NoteAttachmentMasterCardAction.php

Lines 72 to 77 in f369d3b

	/**
	* The attachment attached to the note.
	*
	* @var AttachmentMonetaryAccountPayment[]
	*/
	protected $attachment;

So please remove the [] from the doc and it should be good.

[OGKevin]

so @kojoru this can either be an view definition mistake or the actual response is wrong :)

[basst85]

found it :)

          "attachment": {
                "id": 3647492,
                "description": "",
                "content_type": "image\/jpeg"
            }

is an object but, this is how it's defined:

sdk_php/src/Model/Generated/Endpoint/NoteAttachmentMasterCardAction.php

Lines 72 to 77 in f369d3b

 /** 
  * The attachment attached to the note. 
  * 
  * @var AttachmentMonetaryAccountPayment[] 
  */ 
 protected $attachment; 

So please remove the [] from the doc and it should be good.

Yes! That works indeed. Thanks!

[basst85]

@kojoru Any update on this small bug?

[two-trick-pony-NL]

👋 Hey @basst85

I work at bunq and am currently reviewing the bunq API docs, open issues and SDK’s and came across your issue. I know it’s been open for a while, and I’d love to understand how it’s impacting you. Beyond the obvious -fixing this issue-, what else could we do to improve your experience with our API?

If you want to share your thoughts on how we can improve on our public API:

📅 I'd love to schedule a 15 minute interview to understand your needs through: Calendly
💬 Or if you don't have time for a call, you can give us some general feedback through this form

Your feedback will go straight to our product team! 🚀