Crop

[sepehr1014]

Thank you for this awesome project. You mentioned cropping functionality is next. Is it in active development? What's the expected time frame?

[burhanrashid52]

Crop selection will be added in future release. But for time being you can crop the image using CustomEffect.Builder() which is a wrapper on EffectFacotory check this link.

[sepehr1014]

Thanks but having crop selection would be great. I personally think it's a must for any photo editor.

[DHosseiny]

U think when can you add this future?

[burhanrashid52]

I don't have ETA for it. Currently, my schedule is a little tight this time.
If anyone is able to do it before me than PR's are welcome

[animestanley]

would donation make this feature available :) ?

[burhanrashid52]

Donations are always welcome :) @animestanley

[efreim]

any updates about crop feature? :)

[lucianocheng]

If anyone is able to do it before me than PR's are welcome

@burhanrashid52 do you have an example of cropping you are using for reference?

[burhanrashid52]

@lucianocheng https://github.com/siwangqishiq/ImageEditor-Android/blob/master/imageeditlibrary/src/main/java/com/xinlan/imageeditlibrary/editimage/fragment/CropFragment.java
I am trying to implement into this branch https://github.com/burhanrashid52/PhotoEditor/tree/PE-79 with better API. But still not happy with the result.

[akhilakhi84]

Tried this library Android Image Cropper

Rect cropRect = imageCropView.getCropRect()
CustomEffect customEffect = new CustomEffect.Builder(EffectFactory.EFFECT_CROP)
                        .setParameter("xorigin", cropRect.left)
                        .setParameter("yorigin", cropRect.right)
                        .setParameter("width", cropRect.width())
                        .setParameter("height", cropRect.height())
                        .build();
                photoEditor.setFilterEffect(customEffect);

But its not cropping correctly. tried both imageCropView.getCropRect() and imageCropView.getCropWindowRect()

I think i need the width and height of your FilterImageView

EDIT: finally managed it to get working. But another problem is after cropping the image. the PhotoEditorView shows stretched image.

[amitkle]

@akhilakhi84 can you please elaborate what you did and if you managed to make it work?

[lucianocheng]

For those following this: If your use case is to only crop the image once, before it is loaded, I was able to get this working with uCrop. The solution is blunt: Just crop the incoming image before loading it into the PhotoEditor.

The tricky part about solving this is cropping after the image has stickers, text, etc on it. All the things I've tried involve adding additional layers to the canvas, which isn't great. Also cropping with rotation is a whole other dimension. I don't have a solution I like yet.

[hafiz013]

For me if could manage get photoeditor source and implement fragment dialog to crop image and replace back the image is better.

[sahil0289]

If we can get photoeditorview source then we can crop image..After highlighting image or writing text we cannot get edited image to crop.. How to get edited image??

[mikemike396]

Any update on integrating cropping feature?