Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing py.typed marker #1421

Closed
broken-wheel opened this issue Feb 24, 2024 · 1 comment
Closed

Missing py.typed marker #1421

broken-wheel opened this issue Feb 24, 2024 · 1 comment

Comments

@broken-wheel
Copy link

broken-wheel commented Feb 24, 2024

First of all, thank you for adding type information to gspread.

The package is missing py.typed marker. Because of this, mypy skips type checking for the library (https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker). I verified manually that adding py.typed file to the package does fix the issue.

This will not show up during type checking of the repo itself (i.e., tox -e lint), but only when a downstream user uses the library.

@lavigne958
Copy link
Collaborator

Hi thank you for this, I will work on this and add the missing marker file.

Duplicates #1401
closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants