Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cascade menu in context menu #125

Merged
merged 2 commits into from
Jul 26, 2020
Merged

fix: use cascade menu in context menu #125

merged 2 commits into from
Jul 26, 2020

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jul 26, 2020 •
edited
Loading

This brings all the x-terminal commands into a single menu for easier access:

image

@the-j0k3r
Copy link
Member

the-j0k3r commented Jul 26, 2020 •
edited
Loading

Thanks for this contribution.

Context menus are often overcrowded,

I guess I wouldn't mind this change as it kind of makes some sense.

UziTech
UziTech approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a breaking change?

@the-j0k3r
Copy link
Member

Would this be a breaking change?

I dont even think its a feature.

@UziTech UziTech changed the title feat: use cascade menu for the editor commands fix: use cascade menu in context menu Jul 26, 2020
@UziTech UziTech merged commit 295c699 into bus-stop:master Jul 26, 2020
@github-actions
Copy link

🎉 This PR is included in version 9.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

Assignees
No one assigned
Labels
released 📮 Release has been made
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aminya @the-j0k3r @UziTech