Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix resize when switching docks #129

Merged
merged 2 commits into from
Jul 30, 2020
Merged

fix: fix resize when switching docks #129

merged 2 commits into from
Jul 30, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Jul 27, 2020 •
edited
Loading

Fixes resizing terminal when switching docks

fixes #124

@UziTech UziTech mentioned this pull request Jul 27, 2020
Closed
3 tasks
@UziTech UziTech force-pushed the fix-resize branch 2 times, most recently from 991f7a8 to ad3f61f Compare July 27, 2020 05:04
@UziTech
Copy link
Member Author

UziTech commented Jul 27, 2020

I'm not 100% sure we don't need the intersection observer after the first time it is visible. I'm going to do a little more manual testing before releasing this fix.

@UziTech UziTech marked this pull request as draft July 27, 2020 06:05
@UziTech UziTech marked this pull request as ready for review July 29, 2020 21:39
@UziTech UziTech requested a review from the-j0k3r July 29, 2020 21:54
@UziTech
Copy link
Member Author

UziTech commented Jul 29, 2020

@aminya does this PR fix #124 for you?

aminya
aminya approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! 🎉 I haven't checked the code, but my practical use shows better resizing behavior.

resize

@UziTech UziTech merged commit 888a26b into master Jul 30, 2020
@UziTech UziTech deleted the fix-resize branch July 30, 2020 06:16
@github-actions
Copy link

🎉 This PR is included in version 9.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Jul 30, 2020
@UziTech UziTech mentioned this pull request Aug 3, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya approved these changes

@the-j0k3r the-j0k3r the-j0k3r approved these changes

Assignees
No one assigned
Labels
released 📮 Release has been made
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BR] X-terminal does not change its dimensions by changing the panes dimension
3 participants
@UziTech @aminya @the-j0k3r