Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use the project directory when the cwd is in the project path?[Q] #96

Closed
yangybb45142 opened this issue Jun 13, 2020 · 7 comments · Fixed by #213
Closed

Why use the project directory when the cwd is in the project path?[Q] #96

yangybb45142 opened this issue Jun 13, 2020 · 7 comments · Fixed by #213
Labels
enhancement ⚙️ Improvements or feature being added good first issue 🐝 Good for newcomers released 📮 Release has been made

Comments

@yangybb45142
Copy link

For the initialize() in the model.js, why use the project directory when the cwd is in the project path?

@yangybb45142 yangybb45142 added the question ❓ Further information is requested label Jun 13, 2020
@UziTech
Copy link
Member

UziTech commented Jun 13, 2020

I'm not exactly sure what you are referring to. Could you give an example?

@yangybb45142
Copy link
Author

yangybb45142 commented Jun 14, 2020

Thank you for your reply! Sorry, I didn't make it clear。

Line 80 in /src/model.js of x-terminal, there is the following code:
const dir = atom.project.relativizePath(cwd)[0]
if (dir) {
// Use project paths whenever they are available by default.
this.profile.cwd = dir
return
}

I use x-terminal to start java application. I set the Java application directory to the cwd parameter, I encountered two obstacles:

  1. Classpath lookup error based on relative path;
  2. Log cannot be output to start directory;
    I found that the problem was caused by the code above. The code modifies the startup path of Java application。

I want to know why you did that, or if I have a wrong understanding of the cwd parameter?

@UziTech
Copy link
Member

UziTech commented Jun 14, 2020

I'm not sure why that is like that. If you want to create a PR that adds a setting to disable it I would be happy to review it.

@the-j0k3r
Copy link
Member

the-j0k3r commented Jun 15, 2020

This could be solved by mapping terminal to file.

@UziTech
Copy link
Member

UziTech commented Jun 15, 2020

@the-j0k3r PRs are welcome 😁

@the-j0k3r
Copy link
Member

Preaching to the choir =) there @UziTech? Soon as I know enough to do it, so far Im struggling with catching up from learner to the level needed, never mind the rest.

Also lately more chores needed around the house, so no time for scrambling bits. awww

@UziTech UziTech added enhancement ⚙️ Improvements or feature being added good first issue 🐝 Good for newcomers and removed question ❓ Further information is requested labels Jul 15, 2020
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

🎉 This issue has been resolved in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released 📮 Release has been made label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⚙️ Improvements or feature being added good first issue 🐝 Good for newcomers released 📮 Release has been made
Development

Successfully merging a pull request may close this issue.

3 participants