Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept markupSanitizer option, downcase tagName and attributeName #50

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Mar 2, 2017

Add npm 'start' script, note in readme how to run tests in browser.
Refactor tests to be more DRY (use mobiledoc creation helpers).
Refactor renderers to share more helper functions.
Refactor renderer shape to remove some conditionals (adds
#sectionElementRendererFor and #markupElementRendererFor).

fixes #49
fixes #48

@bantic
Copy link
Contributor Author

bantic commented Mar 2, 2017

supersedes #47.

Add npm 'start' script, note in readme how to run tests in browser.
Refactor tests to be more DRY (use mobiledoc creation helpers).
Refactor renderers to share more helper functions.
Refactor renderer shape to remove some conditionals (adds
`#sectionElementRendererFor` and `#markupElementRendererFor`).

fixes #49
fixes #48
@bantic bantic merged commit aa1aedc into master Mar 6, 2017
@bantic bantic deleted the accept-markup-sanitizer branch March 6, 2017 15:40
@gpoitch
Copy link
Member

gpoitch commented Mar 6, 2017

Seems like you can do this in markupElementRenderer. Perhaps explain that in the readme instead of extending the API surface?

@bantic
Copy link
Contributor Author

bantic commented Mar 6, 2017

@gdub22 good point — I'll make that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sanitizer does not normalize tagName or attribute rendering mobiledoc with href fails in fastboot
2 participants