Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SiestaUI library for Swift Package Manager #301

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

karlshea
Copy link
Contributor

  • SiestaUI library product/target added
  • Copy Collection extension into SeistaUI source, fixing an "inaccessable due to 'internal' protection level" error while building

@pcantrell
Copy link
Member

Thanks for taking this on, @karlshea! Tested locally and it works great!

Two questions before I merge:

  1. Can we avoid duplicating the any/all implementations? Your solution is certainly preferable to making them public to all downstream libraries. Does SwiftPM support internal dependencies, i.e. shared modules exposed only to other modules in the package, and not downstream packages? IIRC it does not, but let’s double check. That failing, your solution is the best one I can see.
  2. SiestaUI can’t load its ResourceStatusOverlay.xib when it’s included via SwiftPM. I think this just isn’t possible until this proposal implemented, but do you know of any workarounds I can put in the docs other than just instructing people to copy that file into their projects if they need it?

@karlshea
Copy link
Contributor Author

karlshea commented Mar 6, 2020

I'm not sure about the answers to either of those—I was using Siesta in my first iOS project so I've been learning as I go. Maybe it would be best to keep this as a PR until someone that really knows the right way to package something for Swift PM can weigh in on the best direction.

@pcantrell
Copy link
Member

I think I’ll merge this so that people can at least use SwiftPM with Siesta, and patch up later (or least investigate to my satisfaction) before cutting an official release.

@pcantrell pcantrell merged commit 0cbb113 into bustoutsolutions:master Mar 6, 2020
@pcantrell
Copy link
Member

Official word from the SwiftPM maintainers themselves:

  1. There is no SwiftPM solution for this, but we can use symlinks with git. I’ll update to do that in a separate PR.
  2. Above is correct. Resource support should land in Swift 5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants