Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images for other architectures (ARM,...) #375

Closed
LeszekBlazewski opened this issue Jan 22, 2022 · 3 comments
Closed

Docker images for other architectures (ARM,...) #375

LeszekBlazewski opened this issue Jan 22, 2022 · 3 comments

Comments

@LeszekBlazewski
Copy link

Is your feature request related to a problem? Please describe.

Hey ! Great app, we are using wetty for multiple hosts connection after wakeup with wake on lan. We are running it on Raspberry PI and currently we are building the image ourselves.

Describe the solution you'd like

Because you already use the setup QUEMU step in github actions, would you mind also building the image for other architectures including ARM? This requires just few lines of modification inside your current workflow :)

Would be great to see docker images for other architectures on your docker hub 💯 ❗

Thanks for the great terminal 😃

@LeszekBlazewski LeszekBlazewski changed the title Support for ARM architecture Docker images for other architectures (ARM,...) Jan 22, 2022
@butlerx
Copy link
Owner

butlerx commented Jan 29, 2022

doyou have a link to docs or guides, ive never looked in to docker for arm builds before but happy to support them

@LeszekBlazewski
Copy link
Author

This is super easy, since you use already the docker pipeline on github actions with QUEMU and BuildX step. I will provide a PR with the update which should work 😄.

Please check this PR: #379 where details are included :)
Let me know what you think!

@butlerx butlerx mentioned this issue Aug 15, 2022
@butlerx
Copy link
Owner

butlerx commented Aug 16, 2022

This should now be resolved. We are publishing multiple arm versions to docker hub and github container registry

Thanks to @LeszekBlazewski for the original change for this and most helpful write up on issues with buildx and yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants