Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-capturing groups not supported #150

Open
mihai-moldovan opened this issue Oct 29, 2018 · 0 comments
Open

Non-capturing groups not supported #150

mihai-moldovan opened this issue Oct 29, 2018 · 0 comments

Comments

@mihai-moldovan
Copy link

Hey,
I'm trying to use this pattern:
"(?:www.)?shop.example.com/collections/:handle([^/]+)"

to match these urls:

https://shop.example.com/collections/new-arrivals
https://www.shop.example.com/collections/fall-2018

but not this url:
https://othersubdomain.shop.example.com/collections/new-arrivals

Unfortunately, if use a non-capturing group, somewhere in the pattern cleaning process, the ":" character confuses the framework.
If I use a normal capturing group: "(www.)?shop.example.com/collections/:handle([^/]+)" still doesn't work because it gets confused with the handle parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant