Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bz_LoadPhy uses base 1 instead of base 0 for labeling channels #264

Open
raswanson opened this issue Oct 28, 2018 · 2 comments
Open

bz_LoadPhy uses base 1 instead of base 0 for labeling channels #264

raswanson opened this issue Oct 28, 2018 · 2 comments
Assignees

Comments

@raswanson
Copy link
Collaborator

Hey guys - just flagging the fact that:

  • bz_LoadPhy uses base 1 for identification of the channel of max waveform for each unit (spikes.maxWaveformCh)
  • bz_GetLFP uses base 0 for channel identification (a la neuroscope)
  • bz_GetSpikes appears to use base 0 (please confirm @DavidTingley)

We should visit this to make sure all are the same.

@brendonw1
Copy link
Collaborator

Basically going forward it of course makes sense to make bz_LoadPhy use base0 to match. But @AntonioFR8 and others who have already used bz_LoadPhy will need to find a way to make this work for them

@raswanson
Copy link
Collaborator Author

Yeah exactly. We were thinking we'd just have to chat with Antonio/Manu tomorrow to see how much that would break :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants