Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to TUI controls #105

Open
alexmaco opened this issue Sep 8, 2021 · 2 comments
Open

Improvements to TUI controls #105

alexmaco opened this issue Sep 8, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@alexmaco
Copy link
Contributor

alexmaco commented Sep 8, 2021

How would you feel about making the keyboard controls more in line with other TUI applications?

/ usually means search/filter, in htop, less, vim, etc. However zenith uses this to reverse the sort order in the process table. I think something like ; (or anything else) would be better for reordering, which frees up / to do the usual free that's already in many muscle memories.

Second, after returning from a per-process view, the filtering mode is not active anymore. So before clearing it, to go back one step further to the unfiltered view, one has to press a key to activate it again. I don't know if this is intended for a usecase, so I would suggest either:

  • that filtering stay active if it was active before zooming into a process
  • use a sort of background highlight/inverted view to emphasize the input field for filtering when it is actually active

Thoughts?

@bvaisvil bvaisvil added the enhancement New feature or request label Sep 9, 2021
@bvaisvil
Copy link
Owner

Changing filtering to be done via / instead of f is fine by me. I'm not married to the table sort keys.

As for filtering being active, that was intentional - but my memory was hazy. I think the issue was after going back from zooming in on a process that it wasn't immediately apparent that your keystrokes would go into the filtering field. I think emphasizing the input field sounds very sensible to me.

@namespaceYcZ
Copy link

I prefer vim-like keymap too.
Why not add [j/k] to navigate up/down, [h/l] to change sort column instead of [,/.], and '?' to toggle help screen instead of 'h'?
If only there were a configuration file for keymap changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants