Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-addons-shallow-compare with PureComponent? #469

Closed
cesarandreu opened this issue Nov 17, 2016 · 9 comments
Closed

Replace react-addons-shallow-compare with PureComponent? #469

cesarandreu opened this issue Nov 17, 2016 · 9 comments

Comments

@cesarandreu
Copy link
Contributor

According to the docs, react-addons-shallow-compare is a legacy addon. Have you considered replacing it with React.PureComponent?

@bvaughn
Copy link
Owner

bvaughn commented Nov 17, 2016

Doesn't seem appropriate for a lib, considering PureComponent is a recent addition and I'm trying to maintain backwards compatibility. I could make that upgrade in the next major release- but it would be backwards-breaking.

@cesarandreu
Copy link
Contributor Author

Ah, that's totally understandable. Do you know if there's any public metrics that show each version's usage? Would it be safe to assume your plan is to follow along with react and drop v14 support when v16 is released?

@bvaughn
Copy link
Owner

bvaughn commented Nov 18, 2016

Hm, no clue. I don't know if even the React team knows that, although I'll ask Ben when I see him.

Yes, that would be reasonable to assume. 😄

@bvaughn
Copy link
Owner

bvaughn commented Nov 20, 2016

Closing for now 😄 We can revisit when next React version drops

@dsifford
Copy link

@bvaughn Can we revisit this? Dropping shallow-compare would be nice because it frees up that pesky peer dependency.

@bvaughn
Copy link
Owner

bvaughn commented Jan 20, 2017

We can revisit once React 16 lands or with the next major react-virtualized released. 😄

@dsifford
Copy link

Sounds good! Sorry, I suppose I should have prefaced that last message with "I have no idea what version React was at when you guys first had this conversation".

** subscribes to thread **

@bvaughn
Copy link
Owner

bvaughn commented Jan 20, 2017

No problem 😄 This ticket was from November '16 and React 15 has been out since April '16, so same major version.

@bvaughn
Copy link
Owner

bvaughn commented Feb 13, 2017

FYI thought you might like to know that the upcoming react-virtualized version 9 will drop support for shallowCompare in favor of using React.PureComponent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants