-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-addons-shallow-compare with PureComponent? #469
Comments
Doesn't seem appropriate for a lib, considering |
Ah, that's totally understandable. Do you know if there's any public metrics that show each version's usage? Would it be safe to assume your plan is to follow along with react and drop v14 support when v16 is released? |
Hm, no clue. I don't know if even the React team knows that, although I'll ask Ben when I see him. Yes, that would be reasonable to assume. 😄 |
Closing for now 😄 We can revisit when next React version drops |
@bvaughn Can we revisit this? Dropping shallow-compare would be nice because it frees up that pesky peer dependency. |
We can revisit once React 16 lands or with the next major react-virtualized released. 😄 |
Sounds good! Sorry, I suppose I should have prefaced that last message with "I have no idea what version React was at when you guys first had this conversation". ** subscribes to thread ** |
No problem 😄 This ticket was from November '16 and React 15 has been out since April '16, so same major version. |
FYI thought you might like to know that the upcoming react-virtualized version 9 will drop support for |
According to the docs, react-addons-shallow-compare is a legacy addon. Have you considered replacing it with React.PureComponent?
The text was updated successfully, but these errors were encountered: